Upgrade openfga to 1.2.0 #1010
Upgrade openfga to 1.2.0 #1010
Conversation
Signed-off-by: Mina Ashraf <[email protected]>
Signed-off-by: Mina Ashraf <[email protected]>
| @@ -81,6 +82,13 @@ func getAuthModelDefinition() (_ []openfga.TypeDefinition, err error) { | |||
| return | |||
| } | |||
|
|
|||
| var ok bool | |||
| schemaVersion, ok = wrapper["schema_version"].(string) | |||
There was a problem hiding this comment.
Thinking about this, we should also check that the OpenFGA charm does this too now.
.gitignore
Outdated
| @@ -18,5 +18,5 @@ local/vault/roleid.txt | |||
| *.crt | |||
| *.key | |||
| *.csr | |||
| jimmctl | |||
| /jimmctl | |||
There was a problem hiding this comment.
jimmctl is a binary no? Why /?
There was a problem hiding this comment.
leaving it as "jimmctl" without specifying that it is in the root level results in ignoring all paths that has jimmctl in it
This includes all files under the directory cmd/jimmctl
There was a problem hiding this comment.
Ooooh, will this still ignore the binary?
There was a problem hiding this comment.
yeah, this specifically ignores the binary and the binary only
| @@ -305,9 +305,9 @@ func (s *accessControlSuite) TestAddRelation(c *gc.C) { | |||
| }, | |||
| //Test group -> controller | |||
| { | |||
| input: tuple{"group-" + "test-group", "administrator", "controller-" + controller.UUID}, | |||
| input: tuple{"group-" + "test-group#member", "administrator", "controller-" + controller.UUID}, | |||
There was a problem hiding this comment.
Surprised this wasn't always like this (considering the comment above)
cmd/jimmctl/cmd/relation_test.go
Outdated
| @@ -204,7 +204,7 @@ func (s *relationSuite) TestRemoveRelationViaFileSuperuser(c *gc.C) { | |||
| file, err := os.CreateTemp(".", "relations.json") | |||
| c.Assert(err, gc.IsNil) | |||
| defer os.Remove(file.Name()) | |||
| testRelations := `[{"object":"group-` + group1 + `","relation":"member","target_object":"group-` + group3 + `"},{"object":"group-` + group2 + `","relation":"member","target_object":"group-` + group3 + `"}]` | |||
| testRelations := `[{"object":"group-` + group2 + `#member","relation":"member","target_object":"group-` + group3 + `"}]` | |||
There was a problem hiding this comment.
How come we remove group 1*?
There was a problem hiding this comment.
will get it back. Forgot it while debugging
Description
Migrating Openfga version from 0.3.4 to 1.2.0
Fixes CSS-4799
Engineering checklist
Check only items that apply