Purge logs cmd #1008
Merged
Purge logs cmd #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I made my comments and forgot to click submit. I see some new commits came through since, will take another look in a bit |
alesstimec
requested changes
Jul 20, 2023
| @@ -79,6 +80,7 @@ func init() { | |||
| r.AddMethod("JIMM", 4, "UpdateMigratedModel", updateMigratedModelMethod) | |||
| r.AddMethod("JIMM", 4, "AddCloudToController", addCloudToControllerMethod) | |||
| r.AddMethod("JIMM", 4, "RemoveCloudFromController", removeCloudFromControllerMethod) | |||
| r.AddMethod("JIMM", 4, "PurgeLogs", purgeLogsMethod) | |||
There was a problem hiding this comment.
not for this PR but for future consideration. Imagine we had clients out there that were already using facade version 4. .then we release these changes and release a new client that is also using client facade version 4.. then they try to use this client to interact with a server that has not been upgraded to include the new method yet - we'd have a problem :)
Signed-off-by: Mina Ashraf <[email protected]>
alesstimec
reviewed
Jul 21, 2023
kian99
approved these changes
Jul 21, 2023
alesstimec
reviewed
Jul 21, 2023
kian99
approved these changes
Jul 21, 2023
| tomorrow := relativeNow.AddDate(0, 0, 1) | ||
| deleted_count, err := s.Database.DeleteAuditLogsBefore(ctx, tomorrow.Format(time.RFC3339)) | ||
| // check that logs have been deleted | ||
| c.Assert(err, qt.IsNil) |
There was a problem hiding this comment.
I would add an assertion that the count of logs in the DB is 1. But not super necessary.
alesstimec
approved these changes
Jul 24, 2023
Signed-off-by: Mina Ashraf <[email protected]>
kian99
reviewed
Jul 25, 2023
ale8k
reviewed
Jul 25, 2023
ale8k
reviewed
Jul 25, 2023
ale8k
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a command and an endpoint in juju that purges logs before a certain date
Fixes CSS-3781
Engineering checklist
Check only items that apply
Test instructions
not yet tested