Defer database event when username is None
#1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Babak K. Shandiz <[email protected]>
kian99
approved these changes
Jul 19, 2023
alesstimec
approved these changes
Jul 21, 2023
charms/jimm-k8s/src/charm.py
Outdated
| @@ -316,6 +316,11 @@ def _on_dashboard_relation_joined(self, event: RelationJoinedEvent): | |||
| def _on_database_event(self, event: DatabaseEvent) -> None: | |||
| """Database event handler.""" | |||
|
|
|||
| if event.username is None: | |||
There was a problem hiding this comment.
possibly if not event.username or not event.password:
charms/jimm/src/charm.py
Outdated
| @@ -161,6 +161,11 @@ def _on_database_event(self, event: DatabaseRequiresEvent): | |||
| event.defer() | |||
| return | |||
|
|
|||
| if event.username is None: | |||
There was a problem hiding this comment.
same here.. but these are really just nitpicks.. feel free to ignore
Signed-off-by: Babak K. Shandiz <[email protected]>
Signed-off-by: Babak K. Shandiz <[email protected]>
Signed-off-by: Babak K. Shandiz <[email protected]>
ale8k
approved these changes
Jul 28, 2023
| @@ -1,6 +1,6 @@ | |||
| markupsafe>=2.0.1 | |||
| Jinja2 >= 2.11.3 | |||
| ops >= 1.4.0 | |||
| ops >= 2.0.0 | |||
kian99
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes data platform libs provide the database event handler with
username=None. This PR fixes the issue by deferring the event.Engineering checklist
Check only items that apply