backports changes back to feature-rebac #1003
Conversation
Signed-off-by: Mina Ashraf <[email protected]>
Signed-off-by: Mina Ashraf <[email protected]>
| if err != nil { | ||
| return apiparams.CrossModelQueryResponse{}, errors.E(op, errors.Code("failed to get models for user")) | ||
| } | ||
| models := make([]dbmodel.Model, len(usersModels)) |
There was a problem hiding this comment.
What is this intermediate slice for? Why can't we just use userModels? I assume userModels holds more than what we want?
There was a problem hiding this comment.
We want only the model segment, not the wrapping struct, so literally m.Model_
| return nil, err | ||
| } | ||
| func (f *formatterParamsRetriever) GetParams(ctx context.Context, model dbmodel.Model) (*status.NewStatusFormatterParams, error) { | ||
| f.model = &model |
There was a problem hiding this comment.
It's a bit surprising that we're setting this equal to the address of the model struct considering we pass in the model as a value and not by reference, I assume the other methods on formatterParamsRetriever expect a pointer and not the struct itself. Just thought I'd point it out.
There was a problem hiding this comment.
I think I rushed these changes, as the retriever is pointer it doesn't need to be but it's pretty harmless tbh
Description
a Backport was done earlier from the featuer-rebac branch to the main branch. Then, some changes were done on the backport that was not mapped back to the feature-rebac branch. This brings back the changes to feature-rebac
Fixes CSS-4779
Engineering checklist
Check only items that apply