CSS-4803 - Vault relation fixes and extra logging #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also added readme file with manual steps for deploying JIMM for future reference.
kian99
requested review from
alesstimec,
babakks,
ale8k and
mina1460
and removed request for
alesstimec
- Vault access address now comes from config as it would be difficult to determine programatically - Added test to ensure JIMM enters an error state
kian99
force-pushed
the
vault-relation-fix
branch
from
aa68871
to
743af33
Compare
ale8k
reviewed
Jul 17, 2023
alesstimec
approved these changes
Jul 19, 2023
| @@ -0,0 +1,48 @@ | |||
| # Description | |||
There was a problem hiding this comment.
this should really live in the jaas-documentation repo..
There was a problem hiding this comment.
Mmmm good point. I think we can leave it here for now and I'll move it in a follow-up
| @@ -499,9 +507,13 @@ def _get_network_address(self, event): | |||
| return str(self.model.get_binding(event.relation).network.egress_subnets[0].network_address) | |||
|
|
|||
| def _on_vault_relation_joined(self, event): | |||
| if self.config.get("vault-access-address") is None: | |||
| logger.error("Missing config vault-access-address for vault relation") | |||
| raise ValueError("Missing config vault-access-address for vault relation") | |||
There was a problem hiding this comment.
can we just enter into blocked status if this is the case? and defer the event?
There was a problem hiding this comment.
The reason I've set it to go into an error state instead is so that it doesn't keep re-retrying endlessly and instead you can set the missing config and then run juju resolve <charm> which will rerun the hook. Maybe that's not the right way to handle it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Engineering checklist
Check only items that apply