Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry install event on certain errors #229

Draft
wants to merge 50 commits into
base: main
Choose a base branch
from
Draft

Retry install event on certain errors #229

wants to merge 50 commits into from

Commits on Jan 17, 2024

  1. Add docstring for attributes.

    @yhaliaw
    yhaliaw committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    96b5d9a View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. Refactor configuration to charm state

    @yhaliaw
    yhaliaw committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    11f7b11 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into refactor/config-charm-state

    @yhaliaw
    yhaliaw committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    cd1e656 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into refactor/config-charm-state

    @yhaliaw
    yhaliaw committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    bd05772 View commit details
    Browse the repository at this point in the history

  4. Fix linting

    @yhaliaw
    yhaliaw committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    a33580e View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into refactor/config-charm-state

    @yhaliaw
    yhaliaw committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    1e4b837 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Fix bugs

    @yhaliaw
    yhaliaw committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    6841425 View commit details
    Browse the repository at this point in the history

  2. [no ci] fmt

    @yhaliaw
    yhaliaw committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    0a87ba1 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. [no ci] Fix test_charm_state unit tests

    @yhaliaw
    yhaliaw committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    948a4ed View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Fix naming conflict

    @yhaliaw
    yhaliaw committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    d1f0f4b View commit details
    Browse the repository at this point in the history

  2. WIP

    @yhaliaw
    yhaliaw committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    58d4427 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. Merge branch 'main' into refactor/config-charm-state

    @yhaliaw
    yhaliaw committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    bb1c35b View commit details
    Browse the repository at this point in the history

  2. Fix merge of event timer

    @yhaliaw
    yhaliaw committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    e3589de View commit details
    Browse the repository at this point in the history

  3. Fix linting issues

    @yhaliaw
    yhaliaw committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    1bdc973 View commit details
    Browse the repository at this point in the history

  4. Fix unit test for charm.py

    @yhaliaw
    yhaliaw committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    90dd4b9 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. Merge branch 'main' into refactor/config-charm-state

    @yhaliaw
    yhaliaw committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    060f740 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. Fix merge problems

    @yhaliaw
    yhaliaw committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    7ce1cbe View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into refactor/config-charm-state

    @yhaliaw
    yhaliaw committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    131c214 View commit details
    Browse the repository at this point in the history

  3. Fix firewall unit test

    @yhaliaw
    yhaliaw committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    44a39a9 View commit details
    Browse the repository at this point in the history

  4. Remove factory.py

    @yhaliaw
    yhaliaw committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    56c003a View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. Merge branch 'main' into refactor/config-charm-state

    @yhaliaw
    yhaliaw committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    b241824 View commit details
    Browse the repository at this point in the history

  2. Fix import error from merge with main

    @yhaliaw
    yhaliaw committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    292fa0c View commit details
    Browse the repository at this point in the history

  3. Fix unit test issue from merge with main

    @yhaliaw
    yhaliaw committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    6c7d404 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. Merge branch 'main' into refactor/config-charm-state

    @yhaliaw
    yhaliaw committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    953c3e8 View commit details
    Browse the repository at this point in the history

  2. Fix merge

    @yhaliaw
    yhaliaw committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    39210b6 View commit details
    Browse the repository at this point in the history

  3. Fix licenses

    @yhaliaw
    yhaliaw committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    381f0f5 View commit details
    Browse the repository at this point in the history

  4. Update error message

    @yhaliaw
    yhaliaw committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    9428325 View commit details
    Browse the repository at this point in the history

  5. Fix unit test and lints

    @yhaliaw
    yhaliaw committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    48f4044 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. Merge branch 'main' into refactor/config-charm-state

    @yhaliaw
    yhaliaw committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    f101cef View commit details
    Browse the repository at this point in the history

  2. Fix issue from merge

    @yhaliaw
    yhaliaw committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    9ca2fd7 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Merge branch 'main' into refactor/config-charm-state

    @yhaliaw
    yhaliaw committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    a11f67f View commit details
    Browse the repository at this point in the history

  2. Fix one integration test

    @yhaliaw
    yhaliaw committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    b1ea589 View commit details
    Browse the repository at this point in the history

  3. Fix integration test

    @yhaliaw
    yhaliaw committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    e52fc83 View commit details
    Browse the repository at this point in the history

  4. Increase the timeout of token change test

    @yhaliaw
    yhaliaw committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    dfa3da4 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. Refactor according to feedback

    @yhaliaw
    yhaliaw committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    72dffed View commit details
    Browse the repository at this point in the history

  2. Fix import

    @yhaliaw
    yhaliaw committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    5f3b667 View commit details
    Browse the repository at this point in the history

  3. [no ci] Apply suggestions from code review 

    Co-authored-by: Christopher Bartz <[email protected]>
    @yhaliaw @cbartz
    yhaliaw and cbartz authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    c46562f View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. Add reasoning of reconcile_interval validation

    @yhaliaw
    yhaliaw committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    7ee3d51 View commit details
    Browse the repository at this point in the history

  2. Fix lint and unit test

    @yhaliaw
    yhaliaw committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    59d400e View commit details
    Browse the repository at this point in the history

  3. Fix unit test

    @yhaliaw
    yhaliaw committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    0c4275f View commit details
    Browse the repository at this point in the history

  4. Revert CharmState in RunnerManagerConfig

    @yhaliaw
    yhaliaw committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    948d3c4 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2024

  1. [no ci] Apply suggestions from code review 

    Co-authored-by: Christopher Bartz <[email protected]>
    @yhaliaw @cbartz
    yhaliaw and cbartz authored Feb 24, 2024
    Configuration menu
    Copy the full SHA
    e6b9b71 View commit details
    Browse the repository at this point in the history

  2. Fix unit test typing

    @yhaliaw
    yhaliaw committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    e79f5f1 View commit details
    Browse the repository at this point in the history

  3. Fix usage of denylist charm config

    @yhaliaw
    yhaliaw committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    6b2a3af View commit details
    Browse the repository at this point in the history

  4. Enter error state to retry install event

    @yhaliaw
    yhaliaw committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    ae1d99f View commit details
    Browse the repository at this point in the history

  5. Add comment on why start event does not need retry

    @yhaliaw
    yhaliaw committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    802859b View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. Merge branch 'main' into bug/install-event-retry

    @yhaliaw
    yhaliaw committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    5edd9a3 View commit details
    Browse the repository at this point in the history

  2. Error handling in install and upgrade hook

    @yhaliaw
    yhaliaw committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    987a985 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. Merge branch 'main' into bug/install-event-retry

    @yhaliaw
    yhaliaw committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    05a8cc1 View commit details
    Browse the repository at this point in the history

  2. Fix rename of variable

    @yhaliaw
    yhaliaw committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    922c7f7 View commit details
    Browse the repository at this point in the history