bin/ubuntu-core-initramfs: build the early initrd from installed ucode packages #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentindavid
force-pushed
the
valentindavid/ucode
branch
from
426f4da
to
fdbf8e9
Compare
valentindavid
force-pushed
the
valentindavid/ucode
branch
from
fdbf8e9
to
22951f8
Compare
|
Tested on Intel NUC. Not tested on AMD. |
| shutil.copyfileobj(f, output) | ||
|
|
||
| def mk_intel_ucode(output_path): | ||
| check_call(['iucode_tool', f'--write-to={output_path}', '/lib/firmware/intel-ucode/']) |
There was a problem hiding this comment.
Should this call /usr/share/initramfs-tools/hooks/intel_microcode? I know that this is the way that this is done atm by the script in the debian folder but I fear that we become out of sync with the way that the distro creates the microcode bits. For instance I see that the script uses --write-earlyfw but that is not here. We can leave it as a TODO if not too practical.
| def mk_amd_ucode(output): | ||
| for path in glob.glob('/lib/firmware/amd-ucode/*.bin'): | ||
| with open(path, 'rb') as f: | ||
| shutil.copyfileobj(f, output) |
There was a problem hiding this comment.
Similar question to the one for intel about using /usr/share/initramfs-tools/hooks/amd64_microcode
Comment on lines
+754
to
+758
| if os.path.exists('/lib/firmware/amd-ucode'): | ||
| with open(os.path.join(microcode_dir, 'AuthenticAMD.bin'), 'wb') as f: | ||
| mk_amd_ucode(f) | ||
| if os.path.exists('/lib/firmware/intel-ucode'): | ||
| mk_intel_ucode(os.path.join(microcode_dir, 'GenuineIntel.bin')) |
There was a problem hiding this comment.
We should check that if it the target arch is amd64 both actually exist and error otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.