bin/ubuntu-core-initramfs: include dbus files for org.freedesktop.systemd1 #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentindavid
approved these changes
Mar 13, 2024
bin/ubuntu-core-initramfs
Outdated
| @@ -326,6 +326,7 @@ def install_systemd_files(dest_dir, sysroot): | |||
| # * Configuration for systemd-tmpfiles | |||
| # TODO: some of this can be cleaned up | |||
| to_include = re.compile(r"^(/usr)?/lib/systemd/system|" | |||
| r"/usr/share/dbus-1/.*/org.freedesktop.systemd1\..*|" | |||
There was a problem hiding this comment.
It seems we are copying services/org.freedesktop.systemd1.service, but this is for user session and is useless in initramfs. It is system-services/org.freedesktop.systemd1.service that is used. Otherwise it looks fine.
There was a problem hiding this comment.
Good point, I've stopped copying that one
…temd1 These were pulled in on uc22, get them back as they are needed by systemd-run when used from snap-bootstrap.
alfonsosanchezbeato
force-pushed
the
include-systemd-dbus
branch
from
4f1eb6b
to
34db0c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were pulled in on uc22, get them back as they are needed by systemd-run when used from snap-bootstrap.