Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bin/ubuntu-core-initramfs: make sure the initramfs can be cross-built #226

Merged

Conversation

alfonsosanchezbeato
Copy link
Member

By using the --root option.

@alfonsosanchezbeato
Copy link
Member Author

Goes on top of #225

@xnox
Copy link
Contributor

xnox commented Jan 23, 2024

Review diff is now confusing, as i think the parent branch got rewritten. Could you please rebase or merge the current development tip please?

@alfonsosanchezbeato
Copy link
Member Author

@xnox rebased now

@Meulengracht Meulengracht marked this pull request as ready for review January 24, 2024 09:55
Copy link

@kubiko kubiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you @alfonsosanchezbeato very nice!

@Meulengracht Meulengracht merged commit d8d6d74 into canonical:main Mar 11, 2024
3 checks passed
@alfonsosanchezbeato alfonsosanchezbeato deleted the cross-build-initramfs branch May 16, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants