Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mkfs.vfat for u-boot gadgets #211

Merged

Conversation

valentindavid
Copy link
Collaborator

Same as #176, but for main branch.

U-boot needs to save boot.sel back to the boot partition. Because ext4 is not safe to write on some U-Boot builds due to journal corruption, we need to allow the gadget to create the boot partition as a vfat. Which means mkfs.vfat is required during installation.

U-boot needs to save `boot.sel` back to the boot partition. Because
ext4 is not safe to write on some U-Boot builds due to journal
corruption, we need to allow the gadget to create the boot partition
as a vfat. Which means `mkfs.vfat` is required during installation.
Copy link

@kubiko kubiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me
Thank you!

Copy link
Member

@alfonsosanchezbeato alfonsosanchezbeato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alfonsosanchezbeato alfonsosanchezbeato merged commit b3aad96 into canonical:main Sep 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants