Add Thread testing #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [WIP] add thread commission test * Split thread test from tests directory, use all clusters snap * Change variables scope * Check log on remote device, replace snap names with consts improve comments * Remove obsolete LFS file, update file names
* fix: commission and validation - Commission via code, without using BLE - Use UTC time on target to ensure consistent queries regardless of local/remote timezones * Merge Go modules, refactor thread tests * Remove unneeded avahi-control connection Inline with doc updates: canonical/matter-docs#22 * Remove unneeded bluetooth interfaces * Add error logging for OTBR failure Getting an error is common when the RCP is disconnected or using a wrong firmware
locnnil
approved these changes
May 2, 2024
There was a problem hiding this comment.
Some notes:
- Would be good if the
remote_execfunction and the SSH logic be moved to the matter-snap-testing library some time in the future. waitForLogMessageandremote_waitForLogMessageare the other two functions that should be moved to the testing library.
On the overall, LGTM! Great job!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most changes have been added by #48 and #52.