Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: github workflow automated build #28

Merged
merged 4 commits into from
Dec 5, 2023
Merged

Conversation

locnnil
Copy link
Contributor

@locnnil locnnil commented Dec 4, 2023

Add automated build on pull requests and commits on branch main.

Add automated build on pull requests and commits on branch main.

Signed-off-by: Lincoln Wallace <[email protected]>
Copy link
Member

@farshidtz farshidtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. It works as expected, but I have some minor suggestion.

Adding some comments and line breaks between the steps is also helpful for increased readability.

.github/workflows/build-snap.yml Outdated Show resolved Hide resolved
.github/workflows/build-snap.yml Outdated Show resolved Hide resolved
Added separation lines and comentaries to improve redability
Use output as snap name to don't leat hardcoded version or architecture.

Signed-off-by: Lincoln Wallace <[email protected]>
Verb tense corrections.

Co-authored-by: Farshid Tavakolizadeh <[email protected]>
@locnnil
Copy link
Contributor Author

locnnil commented Dec 5, 2023

@farshidtz Somehow the build failed, but it seems strange because the actions that occurred in my repository have passed.

Signed-off-by: Lincoln Wallace <[email protected]>
@farshidtz farshidtz merged commit 553333e into canonical:main Dec 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants