-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WD-17951] use different footer for docs pages #1474
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
href="https://www.ubuntu.com/legal">Legal information</a> | ||
</li> | ||
<li class="p-inline-list__item"> | ||
<a class="js-revoke-cookie-manager" href="">Manage your tracker settings</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<a class="js-revoke-cookie-manager" href="">Manage your tracker settings</a> | |
<a class="js-revoke-cookie-manager" href="#">Manage your tracker settings</a> |
If JS is disabled this will refresh the page, it's better that it just does nothing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure I can add that, although this is how it was in multipass.run: https://github.com/canonical/multipass.run/blob/4e54511c235648a61b67d1499af21e98d53bf19a/templates/_layouts/_footer.html#L20C13-L20C89
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose multipass was also wrong
<div class="row"> | ||
<footer class="l-docs__subgrid"> | ||
<div class="l-docs__sidebar"> | ||
<p style="padding-left: 1.5rem"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<p style="padding-left: 1.5rem"> | |
<p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed an example from https://vanillaframework.io/docs/layouts/documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is the full-width site example. The one used here https://microk8s.io/docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think wrapping the whole docs page with "l-docs" class would be tricky, considering it currently extends base_index.html. How about I wrap only the docs footer? |
@akbarkz We managed to do this in the other micro sites, it just required some extra work in jinja, out of scope for this piece of work but still needs to be done. I still don't think you should use the |
Done
Moved a footer that was implemented for multipass.run's Docs pages some time ago into canonical.com and used it for all Docs pages on canonical.com.
QA
Issue / Card
Fixes https://warthogs.atlassian.net/browse/WD-17951
Screenshots
Normal footer:
Docs footer: