fix: use more generic tolerations for promtail #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
Adding taints to your nodes would mean having to add tolerations to Promtail, since this application is required to be deployed on all nodes to receive the logs and send them to Loki.
Before, we only added a specific toleration on the SKS variant to allow Promtail to be deployed on the router nodes, but I've since considered it better to have a more generic toleration, similar to the one from Prometheus Node Exporter DaemonSet. I did not find it necessary to variabilize these tolerations any further.
Breaking change
Tests executed on which distribution(s)