feat!: remove the cluster_id variable || fix: remove the working_directory attribute in the compactor config #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating an SKS cluster, Exoscale used to provision a cluster domain value of `<CLUSTER_ID>.cluster.local`. This is the legacy value for SKS cluster domain. They recently transitioned to provisioning SKS cluster with the default cluster domain value of `cluster.local`. Consequently, we need to remove the adaptations on our modules that were there to support this bizarre, and now legacy, behavior.
This [flag](grafana/helm-charts@824e3da#diff-c09523f8c89a2fdb980fa9bb57eebcbb45a5950391a6bb8d44b549ea184388f6) was hardcoded before and was removed on the version 0.79.x of the chart. As a consequence, it seems that the attribute `compactor.working_directory' was taking its place and breaking our deployments. As a fix, I've decided to revert to the default configuration which uses the `/var/loki` directory (which is mounted as a persistent volume created automatically, as defined by our values).
lentidas
changed the title
jbarascut
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
When creating an SKS cluster, Exoscale used to provision a cluster domain value of
<CLUSTER_ID>.cluster.local. This is the legacy value for SKS cluster domain.They recently transitioned to provisioning SKS cluster with the default cluster domain value of
cluster.local.Consequently, we need to remove the adaptations on our modules that were there to support this bizarre, and now legacy, behavior.
I also fixed a problem we had in the SKS, EKS and KinD configurations that was preventing
loki-compactorfrom being correctly deployed from the v8.2.0 version of the module -> see this commit message for further explanations.Breaking change
cluster_idwas removed from the SKS variantTests executed on which distribution(s)