fix!: remove the namespace variable, hardcode the Helm release name and other AKS changes #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We found out that on multiple modules we were referencing resources from other modules using their default namespaces and this was hardcoded. In case someone decided to change the namespace of deployment of a certain application, this could break the way modules work with each other. We've decided that in order to avoid undefined behaviors caused by overloading this variable, it would be best to remove it entirely.
Since we are hardcoding the namespace variable on all modules, the variable to set the ArgoCD namespace will no longer be needed as well.
I found out that Argo CD passes the name of the application as a value to set the Helm chart. This means that all the templating that used `{ $.Release.Name }` would resolve to the name given to Argo CD application.
In a multicluster deployment, using a single Argo CD, the names of the applications must be different. We solved that by appending the cluster name to the default application name when deploying on different clusters than `in-cluster`. However, this resulted in multiple problems for deployments that depended on the name of the application being static, so this solves that.
This is a breaking change because sometimes this requires an application to be deleted and recreated.
lentidas
force-pushed
the
fix/namespace_release_name
branch
from
e99e849
to
0cce23f
Compare
lentidas
changed the title
jbarascut
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
The main changes of this PR are the following:
fix!: hardcode the release name to remove the destination cluster
I found out that Argo CD passes the name of the application as a value to set the Helm chart. This means that all the templating that used
{ $.Release.Name }would resolve to the name given to Argo CD application.In a multicluster deployment, using a single Argo CD, the names of the applications must be different. We solved that by appending the cluster name to the default application name when deploying on different clusters than
in-cluster. However, this resulted in multiple problems for deployments that depended on the name of the application being static, so this solves that.This is a breaking change because sometimes this requires an application to be deleted and recreated.
fix!: remove the namespace variable
We found out that on multiple modules we were referencing resources from other modules using their default namespaces and this was hardcoded. In case someone decided to change the namespace of deployment of a certain application, this could break the way modules work with each other.
We've decided that in order to avoid undefined behaviors caused by overloading this variable, it would be best to remove it entirely.
fix!: remove the ArgoCD namespace variable
Since we are hardcoding the namespace variable on all modules, the variable to set the ArgoCD namespace will no longer be needed as well.
fix(aks): remove image tag because chart has been upgraded
I noticed the chart had been upgraded, so we no longer need to hardcode the image tag of the application, because the chart supports workload identities.
Breaking change
namespaceandargocd_namespacevariables and the fact that overloading the release name can force a recreation of the application.Tests executed on which distribution(s)