Add display name in the user for better OpenID Connect support #11402
+99
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrunner
force-pushed
the
GSBLGEOS-35-add-user-display
branch
8 times, most recently
from
89a204f
to
b4c970f
Compare
From the artifact of the previous workflow run
sbrunner
force-pushed
the
GSBLGEOS-35-add-user-display
branch
from
bf406d4
to
b6812fc
Compare
ger-benjamin
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we don't use the
subto make the user link, that's supposed to be used, by adding the display name we can use it in the name.Open question: should the display name be optional (in this case, if he is empty, we will use the username)