Normalization of error status and code allowed values #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PedroDiez
requested review from
shilpa-padgaonkar,
rartych,
patrice-conil and
RubenBG7
as code owners
eric-murray
reviewed
Nov 4, 2024
eric-murray
reviewed
Nov 4, 2024
eric-murray
reviewed
Nov 4, 2024
Co-authored-by: Eric Murray <[email protected]>
Co-authored-by: Eric Murray <[email protected]>
…o normalize_error_status_code_enums_in_error_responses
|
PR ready for review (@patrice-conil, @eric-murray, @rartych, @shilpa-padgaonkar) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This PR aims to define a normalization of error
statusandcodeallowed values for CAMARA APIs, by means of the use of a common chema model that can be applied for every excepction scenario.Taking advantage of this PR also a correction is managed:
422 UNSUPPORTED_DEVICE_IDENTIFIERSexception renamed to422 UNSUPPORTED_IDENTIFIERindicated in API Design guidelines is also included inCAMARA_common.yamlAlso making exceptions alignment as per this comment in
CAMARA_common.yaml. Updates in API Design guidelines Section 6.2 will be managed by Update error codes and info.description template for device / phone number identifiers #324 and Enhancements and Alignments in Errors #329Which issue(s) this PR fixes:
Fixes #196
Does this PR introduce a breaking change?
Special notes for reviewers:
Documentation impacted:
Once this PR is agreed (i.e. the baseline), other artifacts would have to be updated:
We can talk this point in the next commonalities meeting (14/10) and aligned this with @bigludo7
Changelog input
Additional documentation
N/A