Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken DPV link removed, broken link to API Versioning in CAMARA wiki was corrected #311

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

rartych
Copy link
Collaborator

@rartych rartych commented Oct 9, 2024

What type of PR is this?

  • correction

What this PR does / why we need it:

To avoid maintenance problems in 2 documents: Commonalities and ICM, the external link to W3C DPV is kept in the ICM doc.
Paragraph in 11.6 API Design Guidelines was modified.
The broken link to API Versioning detailed description in CAMARA wiki was corrected

Additionally space character was added in line 1469 for better readability.

Which issue(s) this PR fixes:

Fixes #301 #318

Special notes for reviewers:

This PR provides correction to 0.4.0 version and introduces changes into maintenance branch according to Release Management guidelines:
camaraproject/ReleaseManagement#93
https://lf-camaraproject.atlassian.net/wiki/spaces/CAM/pages/14559630/API+Release+Process#PATCH-update

When approved the changes should be merged into main branch as valid for the next release.
The patch release (v0.4.1) should be prepared if no other corrections are needed.

Changelog input

Broken link to DPV document removed
broken link to API Versioning in CAMARA wiki was corrected

PedroDiez
PedroDiez previously approved these changes Oct 9, 2024
Copy link
Collaborator

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rartych rartych linked an issue Oct 14, 2024 that may be closed by this pull request
@rartych rartych added the correction correction in documentation label Nov 18, 2024
@rartych rartych changed the title Broken DPV link removed Broken DPV link removed, broken link to API Versioning in CAMARA wiki was corrected Nov 21, 2024
Copy link
Collaborator

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@shilpa-padgaonkar shilpa-padgaonkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

Copy link
Collaborator

@patrice-conil patrice-conil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rartych rartych linked an issue Nov 25, 2024 that may be closed by this pull request
@rartych rartych merged commit 4769f00 into maintenance-0.4 Nov 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
correction correction in documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken API versioning wiki link in design guidelines Broken link to dpv document
4 participants