Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Carrier Billing Refund API Readiness file name #171

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

PedroDiez
Copy link
Collaborator

What type of PR is this?

  • correction

What this PR does / why we need it:

PR to fix typo in API Readiness file name for Carrier Billing Refund

Which issue(s) this PR fixes:

Fixes #170

Special notes for reviewers:

N/A

Changelog input

Fix Carrier Billing Refund API Readiness file name

Additional documentation

N/A

@PedroDiez PedroDiez self-assigned this Aug 14, 2024
@PedroDiez PedroDiez added the correction API specification needs correction label Aug 14, 2024
@PedroDiez PedroDiez requested a review from rartych August 14, 2024 09:20
Copy link

github-actions bot commented Aug 14, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.03s
✅ OPENAPI spectral 2 0 3.99s
✅ REPOSITORY git_diff yes no 0.05s
✅ REPOSITORY secretlint yes no 1.05s
✅ YAML yamllint 2 0 0.84s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@hdamker
Copy link
Contributor

hdamker commented Aug 15, 2024

As you are anyway renaming the file:

Completely in line with the Release Management documentation would be: api-name-API-Readiness-Checklist.md, resulting in
carrier-billing-refund-API-Readiness-Checklist.md
carrier-billing-API-Readiness-Checklist.md

Currently we are using no scripts to link the files, but if ...

Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PedroDiez PedroDiez merged commit 9a3c7a3 into main Aug 19, 2024
1 check passed
@PedroDiez PedroDiez deleted the fix_API_readiness_cb_refund_file_name branch October 10, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
correction API specification needs correction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correction of API Readiness Checklist name
3 participants