-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release r1.1 (Release Candidate) #167
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Rafal Artych <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@PedroDiez @rartych The PR seems to be in quite good shape. Is there anything open to be done before the release candidate can be created? Also #166 seem to be ready? I have proactively created camaraproject/ReleaseManagement#70 for the review through Release Management, but please add @camaraproject/release-management_maintainers as reviewer if you want to get the review and approval by them. |
Hi @hdamker! Yes it is ready to be merged. |
To be formally correct and following the note below the table:
the status in 7th row of Readiness checklists in RC.1 needs to be changed to:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Release PR approved - on behalf of Release Management
@PedroDiez @rartych One small final point spotted ... will support with the merge afterwards. |
Thanks for the review Herbert |
Co-authored-by: Herbert Damker <[email protected]>
Merging on behalf of Codeowners |
Many thanks @hdamker! |
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Generation of release r1.1 (release candidate) for Carrier Billing APIs Family
This release candidate r1.1 contains the definition and documentation of
The API definition(s) are based on
Which issue(s) this PR fixes:
Fixes #164
Special notes for reviewers:
Changelog input
Additional documentation
N/A