Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release r1.1 (Release Candidate) #167

Merged
merged 8 commits into from
Aug 8, 2024
Merged

Release r1.1 (Release Candidate) #167

merged 8 commits into from
Aug 8, 2024

Conversation

PedroDiez
Copy link
Collaborator

@PedroDiez PedroDiez commented Jul 18, 2024

What type of PR is this?

Add one of the following kinds:

  • documentation
  • subproject management

What this PR does / why we need it:

Generation of release r1.1 (release candidate) for Carrier Billing APIs Family

This release candidate r1.1 contains the definition and documentation of

  • Carrier Billing v0.3.0-rc.1
  • Carrier Billing Refund v0.1.0-rc.1

The API definition(s) are based on

  • Commonalities v0.4.0
  • Identity and Consent Management v0.2.0

Which issue(s) this PR fixes:

Fixes #164

Special notes for reviewers:

Changelog input

 Carrier Billing Release r1.1

Additional documentation

N/A

Copy link

github-actions bot commented Jul 18, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.03s
✅ OPENAPI spectral 2 0 4.05s
✅ REPOSITORY git_diff yes no 0.05s
✅ REPOSITORY secretlint yes no 0.98s
✅ YAML yamllint 2 0 0.85s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

bigludo7
bigludo7 previously approved these changes Jul 19, 2024
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Outdated Show resolved Hide resolved
Co-authored-by: Rafal Artych <[email protected]>
bigludo7
bigludo7 previously approved these changes Jul 19, 2024
Copy link
Collaborator

@rartych rartych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hdamker
Copy link
Contributor

hdamker commented Jul 31, 2024

@PedroDiez @rartych The PR seems to be in quite good shape. Is there anything open to be done before the release candidate can be created? Also #166 seem to be ready?

I have proactively created camaraproject/ReleaseManagement#70 for the review through Release Management, but please add @camaraproject/release-management_maintainers as reviewer if you want to get the review and approval by them.

@PedroDiez PedroDiez requested a review from a team August 1, 2024 09:35
@PedroDiez
Copy link
Collaborator Author

PedroDiez commented Aug 1, 2024

@PedroDiez @rartych The PR seems to be in quite good shape. Is there anything open to be done before the release candidate can be created? Also #166 seem to be ready?

I have proactively created camaraproject/ReleaseManagement#70 for the review through Release Management, but please add @camaraproject/release-management_maintainers as reviewer if you want to get the review and approval by them.

Hi @hdamker! Yes it is ready to be merged.
Anycase let's follow the "formal" procedure. Have been added RM maintainers to wait for their approval. Indeed it was a doubt that I was to query in today's CB meeting, 100% clear with your comment. Many thanks for helping on this!

@rartych
Copy link
Collaborator

rartych commented Aug 2, 2024

To be formally correct and following the note below the table:

"tbd" is in case an alpha or release-candidate API version does not yet provide all mandatory assets for the release

the status in 7th row of Readiness checklists in RC.1 needs to be changed to:

Nr API release assets alpha release-candidate initial
public
stable
public
Status Comments
7 Basic API test cases & documentation O M M M tbd link

Copy link
Collaborator

@rartych rartych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release PR approved - on behalf of Release Management

README.md Outdated Show resolved Hide resolved
@hdamker
Copy link
Contributor

hdamker commented Aug 7, 2024

@PedroDiez @rartych One small final point spotted ... will support with the merge afterwards.

@PedroDiez
Copy link
Collaborator Author

@PedroDiez @rartych One small final point spotted ... will support with the merge afterwards.

Thanks for the review Herbert

Co-authored-by: Herbert Damker <[email protected]>
@PedroDiez PedroDiez requested a review from hdamker August 7, 2024 16:49
@hdamker
Copy link
Contributor

hdamker commented Aug 8, 2024

Merging on behalf of Codeowners

@hdamker hdamker closed this Aug 8, 2024
@hdamker hdamker reopened this Aug 8, 2024
@hdamker hdamker merged commit 2a78936 into main Aug 8, 2024
2 checks passed
@hdamker hdamker deleted the r1.1 branch August 8, 2024 13:24
@PedroDiez
Copy link
Collaborator Author

Many thanks @hdamker!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate Release Candidate Carrier Billing versions for Meta Release v0.4 - Fall24
4 participants