Fix - ProgressBar crashes app in new arch on android #4568
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In new arch android, ProgressBar crashes app when long length float value is used in
progress
Error log: Warning: Error: Exception in HostFunction: Loss of precision during arithmetic conversion: (long) 33.33333333333333
So I did a fix and now we can't have long decimal numbers in
accessibilityValue
Related issue
#4544
Test plan
To reproduce a bug put in ProgressBar prop
progress={0.07}
0.07*100 in JS is equal to 7.000000000000001
and that was my case.
I tested using dependencies:
"expo": "^52.0.0",
"react-native": "0.76.3",
"react-native-paper": "^5.12.5"
Everything works fine now