Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(animated-fab): label styling (web) #4567

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BogiKay
Copy link
Contributor

@BogiKay BogiKay commented Nov 28, 2024

Motivation

Currently, whole styling related logic in AnimatedFAB component relies on onTextLayout, which is mobile specific, so FAB's label is not styled well in web.

Related issue

#4478

Test plan

  • Animated FAB is looking good when example app is running in web browser and there's no regression for mobile devices.

@BogiKay BogiKay requested review from gedu and lukewalczak November 28, 2024 13:37
@BogiKay BogiKay self-assigned this Nov 28, 2024
@callstack-bot
Copy link

Hey @BogiKay, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants