fix: android bottom tabs crash fix when used with react-native-screens #4550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maciej Budziński <[email protected]>
|
Hey @maciekBudzinski, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
|
This fix is essential for resolving my issue with BottomTabNavigation. Please merge it soon. :) |
|
We urgently need this fix. Thank, |
|
this doesn't wok on android. had to set |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue with
MaterialBottomTabsNavigatorwhen used withreact-native-screensby settingremoveClippedSubviewsforBottomNavigationscene to false.Motivation
Having this flag set to
truewas causing android application to crash when theMaterialBottomTabsNavigatorwas used inside native stack navigator.Related issue
Closes #4546
Test plan
Tested on https://github.com/maciekBudzinski/rnp-material-bottom-tabs-repro-issue
Before:
before.webm
After:
after.webm