Skip to content
This repository has been archived by the owner on Aug 17, 2021. It is now read-only.

Format date #137

Draft
wants to merge 3 commits into
base: staging
Choose a base branch
from
Draft

Format date #137

wants to merge 3 commits into from

Conversation

wonderlandpark
Copy link
Member

closes: #136

@wonderlandpark wonderlandpark added the enhancement New feature or request (issue) label Nov 5, 2020
@wonderlandpark wonderlandpark self-assigned this Nov 5, 2020
@wonderlandpark wonderlandpark marked this pull request as draft November 5, 2020 13:21
kijk2869
kijk2869 suggested changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@kijk2869 kijk2869 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make it as discord.py ext custom converter

@wonderlandpark
Copy link
Member Author

Make it as discord.py ext custom converter

What to Change

@kijk2869
Copy link
Contributor

kijk2869 commented Nov 5, 2020 •
edited
Loading

Make it as discord.py ext custom converter

What to Change

If there is not data, raise ValueError
Or there is date, return datetime.datetime object.

Also, make it class object

If you want to learn more, look Advance Converter on that link.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kijk2869 kijk2869 kijk2869 requested changes

@kndlr kndlr Awaiting requested review from kndlr

@SaidBySolo SaidBySolo Awaiting requested review from SaidBySolo SaidBySolo is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@wonderlandpark wonderlandpark

Labels
enhancement New feature or request (issue)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

다양한 포맷의 날짜 지원
2 participants
@wonderlandpark @kijk2869