Fix prevent false positive is valid #131
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asyncLiz
reviewed
May 24, 2024
| @@ -1,4 +1,6 @@ | |||
| import { expect, fixture, html } from '@open-wc/testing'; | |||
| import '@material/web/radio/radio.js' | |||
There was a problem hiding this comment.
drive-by comment, I wouldn't recommend importing a final implementation of a component, there's a lot going on in MWC's radio that would make this difficult to reliably test.
Instead, I'd try to see what <md-radio> is doing that isn't working and create a minimal reproduction class like TestInput.
There was a problem hiding this comment.
tahnks @asyncLiz you are rigth - however, my own bandwidth is too limited at the moment to dive deeper into radio internals (and no webkit available to play around with devtools).
asyncLiz
reviewed
May 24, 2024
christophe-g
force-pushed
the
fix-prevent-false-positive-isValid
branch
from
e3b61ce to
a2e203a
Compare
This is to allow run playwright webkit on linux Mint
This is to test scenario like material-components/material-web#5626 (comment)
christophe-g
force-pushed
the
fix-prevent-false-positive-isValid
branch
from
a2e203a to
18145e1
Compare
|
any updates? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix material-components/material-web#5626 (comment)