Fix element not calling attach internals #130
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asyncLiz
reviewed
May 24, 2024
christophe-g
force-pushed
the
fix-element-not-calling-attach-internals
branch
2 times, most recently
from
906d195 to
df3a298
Compare
|
Let’s rebase this and I’ll get it reviewed/merged. Appreciate the contribution @christophe-g and the feedback in the PR @asyncLiz. |
This is to allow run playwright webkit on linux Mint
christophe-g
force-pushed
the
fix-element-not-calling-attach-internals
branch
from
4441adb to
96428e8
Compare
|
@calebdwilliams - rebased against latest commit. |
calebdwilliams
requested changes
Sep 27, 2024
| @@ -393,9 +393,6 @@ export function forceElementInternalsPolyfill(forceCustomStateSet = true) { | |||
| } else if (this.tagName.indexOf('-') === -1) { | |||
| throw new Error(`Failed to execute 'attachInternals' on 'HTMLElement': Unable to attach ElementInternals to non-custom elements.`); | |||
| } | |||
| if (internalsMap.has(this)) { | |||
There was a problem hiding this comment.
I'm not sure this is the right fix. This is removing a guard against attaching a second internals instance. I think a better fix would be to not call upgrade internals if an instance it doesn't exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #127
The regression test does not pass on webkit without the fix