fix: properly handle static called on type for query #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebdw
force-pushed
the
static_models
branch
from
d27d5f4 to
3c15b82
Compare
|
Hi, Just FYI, the problem fixed itself with a new phpstan patch release => https://github.com/phpstan/phpstan/releases/tag/1.12.2 But, it's still a good idea to have this I think... |
|
@rcerljenko, thanks for the comment, however, I'm not sure what you think the problem is, but this is still needed---the tests I introduced in this PR fail even when PHPStan 1.12.2 is used |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream PR: larastan#2030