Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Plain chat #18284

Merged
merged 27 commits into from
Dec 26, 2024
Merged

feat: Plain chat #18284

merged 27 commits into from
Dec 26, 2024

Conversation

nizzyabi
Copy link
Contributor

@nizzyabi nizzyabi commented Dec 20, 2024

What does this PR do?

This PR replaces the main intercom chat with plain.com's live chat feature.

Mandatory Tasks (DO NOT REMOVE)

  • [Y ] I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • [ Y] I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • [ Y] I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
    PLAIN_CHAT_ID=
    PLAIN_CHAT_HMAC_SECRET_KEY=
  • What are the minimal test data to have?
    Post requests to plain.com
  • What is expected (happy path) to have (input and output)?
    Able to see user messages in plain
  • Any other important info that could help to test that PR

Checklist

@graphite-app graphite-app bot requested review from a team December 20, 2024 03:58
Copy link
Contributor

github-actions bot commented Dec 20, 2024

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Plain chat WIP". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@keithwillcode keithwillcode added the core area: core, team members only label Dec 20, 2024
Copy link

graphite-app bot commented Dec 20, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/20/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (12/20/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (12/26/24)

1 label was added to this PR based on Keith Williams's automation.

Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Dec 26, 2024 6:22pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Dec 26, 2024 6:22pm

@github-actions github-actions bot added the ❗️ .env changes contains changes to env variables label Dec 20, 2024
Copy link

socket-security bot commented Dec 20, 2024

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@hbjORbj hbjORbj changed the title Plain chat WIP feat: Plain chat WIP Dec 20, 2024
@hbjORbj hbjORbj marked this pull request as draft December 20, 2024 23:04
@hbjORbj hbjORbj changed the title feat: Plain chat WIP feat: Plain chat Dec 20, 2024
@hbjORbj
Copy link
Contributor

hbjORbj commented Dec 20, 2024

@dosubot dosubot bot added the ✨ feature New feature or request label Dec 26, 2024
: customer.emailVerified
? "GREEN"
: "RED",
customer.emailVerified === undefined ? "No" : customer.emailVerified ? "Yes" : "No",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
customer.emailVerified === undefined ? "No" : customer.emailVerified ? "Yes" : "No",
customer.emailVerified ? "Yes" : "No",

}
`;

useEffect(() => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This duplicates the hook logic; what do you say about moving this into the hook entirely?

PeerRich and others added 15 commits December 26, 2024 13:11
Co-authored-by: Syed Ali Shahbaz <[email protected]>
…pp router metadata logic (#18348)

* remove HeadSeo for already migrated pages and refactor prepareMetadata

* create _generateMetadataWithoutImage and refactor _generateMetadata
* chore: app router - /bookings page

* remove env vars

* fix

* Update middleware.ts

* revert unneeded change

* refactor for the better

* fix
Co-authored-by: CarinaWolli <[email protected]>
Co-authored-by: sean-brydon <[email protected]>
Co-authored-by: sean-brydon <[email protected]>
Co-authored-by: Peer Richelsen <[email protected]>
Co-authored-by: Omar López <[email protected]>
…g parent (#18059)

* fix: metadata is overwirten

* Update

* type error

* Update

* fix test

* fix type error
* Added routing form support link

* small change

* Type fix

---------

Co-authored-by: Joe Au-Yeung <[email protected]>
* refactor handling logic for embeds in app router

* fix type checks

* add test for withEmbedSsrAppDir

* fix
@CLAassistant
Copy link

CLAassistant commented Dec 26, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
6 out of 7 committers have signed the CLA.

✅ nizzyabi
✅ Udit-takkar
✅ vijayraghav-io
✅ hbjORbj
✅ emrysal
✅ anikdhabal
❌ calcom-bot
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@emrysal emrysal enabled auto-merge (squash) December 26, 2024 18:36
Copy link
Contributor

github-actions bot commented Dec 26, 2024

E2E results are ready!

@emrysal emrysal merged commit 225313e into main Dec 26, 2024
58 of 60 checks passed
@emrysal emrysal deleted the plain-chat branch December 26, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only ❗️ .env changes contains changes to env variables ✨ feature New feature or request ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.