Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Overlay my calendar default behaviour #18155

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Overlay my calendar default behaviour #18155

wants to merge 2 commits into from
+1 −1

Conversation

suyash5053
Copy link
Contributor

What does this PR do?

Loom Video: https://www.loom.com/share/a54582be13ce46249a4f9bc70dc98af3?sid=3e25eb68-d2d1-48e0-b91a-06185f94710b

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. NA
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

Checklist

  • I haven't checked if my changes generate no new warnings

@vercel Vercel
Copy link

vercel bot commented Dec 13, 2024

Deployment failed with the following error:

The provided GitHub repository does not contain the requested branch or commit reference. Please ensure the repository is not empty.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Dec 13, 2024
@graphite-app graphite-app bot requested a review from a team December 13, 2024 04:38
@github-actions GitHub Actions
Copy link
Contributor

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Overlay my calendar default behaviour". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@github-actions github-actions bot added calendar-apps area: calendar, google calendar, outlook, lark, microsoft 365, apple calendar ✨ feature New feature or request 🧹 Improvements Improvements to existing features. Mostly UX/UI labels Dec 13, 2024
@dosubot dosubot bot added the bookings area: bookings, availability, timezones, double booking label Dec 13, 2024
@dosubot dosubot bot added this to the v4.9 milestone Dec 13, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Dec 13, 2024 •
edited
Loading

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/13/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (12/13/24)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (12/13/24)

1 label was added to this PR based on Keith Williams's automation.

@suyash5053 suyash5053 changed the title Overlay my calendar default behaviour feat: Overlay my calendar default behaviour Dec 13, 2024
Praashh
Praashh approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@Praashh Praashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@github-actions GitHub Actions
Copy link
Contributor

E2E results are ready!

anikdhabal
anikdhabal requested changes Dec 13, 2024
View reviewed changes
packages/features/bookings/Booker/components/OverlayCalendar/OverlayCalendarSwitch.tsx
@@ -20,7 +20,7 @@ export function OverlayCalendarSwitch({ enabled, hasSession, onStateChange }: Ov
(state) => state.setCalendarSettingsOverlayModal
);
const layout = useBookerStore((state) => state.layout);
const switchEnabled = enabled;
const switchEnabled = hasSession || enabled;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is enabled, but does it overlay the calendar? Please share a Loom with the connected calendar

Copy link
Contributor

@sanchitttt sanchitttt Dec 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a thought – by setting this as const switchEnabled = hasSession || enabled;, wouldn't it always return true for signed-in users, potentially causing the button to never close visually?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is enabled, but does it overlay the calendar? Please share a Loom with the connected calendar

did exactly that here:
#18191

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@retrogtx retrogtx retrogtx left review comments

@sanchitttt sanchitttt sanchitttt left review comments

@anikdhabal anikdhabal anikdhabal requested changes

@Praashh Praashh Praashh approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
bookings area: bookings, availability, timezones, double booking calendar-apps area: calendar, google calendar, outlook, lark, microsoft 365, apple calendar community Created by Linear-GitHub Sync ✨ feature New feature or request 🧹 Improvements Improvements to existing features. Mostly UX/UI ready-for-e2e
Projects
None yet
Milestone
v4.9
Development

Successfully merging this pull request may close these issues.

[CAL-4882] turn "overlay your calendar" on by default if signed in
5 participants
@suyash5053 @sanchitttt @retrogtx @anikdhabal @Praashh