-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: makes production build ready for docker #12686
chore: makes production build ready for docker #12686
Conversation
@alannnc is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Adrián Darío Hidalgo Flores seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
Page | Size (compressed) |
---|---|
global |
163.8 KB (🟡 +612 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
…l.com into fix-production-build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the proposal seems to be simple and fair. We cannot merge any of these until all of the checks are passing.
The repository may have some build Issues that should be attended to fix some types of errors, meanwhile, you can run DISABLE_ESLINT_PLUGIN=true NODE_ENV=production CI=true yarn build to avoid those errors
We cannot allow this on main unfortunately.
Hey there, there is a merge conflict, can you take a look? |
Converting to draft while conflicts are fixed |
This PR is being marked as stale due to inactivity. |
Closing in favor of #13541 |
What does this PR do?
This PR modifies how you can use environment variables on runtime to have "one build, many deployments". With this update, you can now build Docker images, so anybody can deploy with their own environments.
This fix allows PR #313 to work correctly.
Fixes #12032
Requirement/Documentation
Type of change
How should this be tested?
DISABLE_ESLINT_PLUGIN=true NODE_ENV=production CI=true yarn build
to avoid those errorsyarn start
to test