[feat] Info Hover Message for COD and KDMs #98 #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 11, 2024 23:12
There was a problem hiding this comment.
We won't merge this in until after finals week (which is fine since this was not a set feature for the MTP) but here are a few things we will need to address
- It should be grey, except for the key word. etc "COD" will be blue and in bold, but everything else will be grey.
- The container should be wider, rn it's quite narrow so everything looks really squashed. After finals week I'll try to use figma to design how all the infocontainers should look like
- At a second glance, I think I want the infohovers on all KDMs to describe them (not just what NYSERDA and NYSIO stands for). For this we will require the NPO to send their own descriptions which I will request during MTP handoff
These are a lot of changes so we will handle them after finals week.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR
Description
Screenshots
How to review
Next steps
Relevant links
Online sources
Related PRs
CC: @itsliterallymonique