SQL Server adapter uses nvarchar(max) instead of ntext and always updates default constraint #1977
+13
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 28, 2021 16:18
ALTER TABLE COLUMN calls error out unless the constraint is properly removed prior. This removes the logic of determining if the default changes, as the database doesn't care if it does or not.
TEXT types have been deprecated for years and VARCHAR(MAX) has been the recommended type to use. This changes the translation to use nvarchar(max) instead. Also ensures that there isn't a limit set when retrieving text columns, to keep this abstracted away.
dereuromark
reviewed
Apr 29, 2021
No need for an else with an early return.
dereuromark
reviewed
Jun 2, 2021
dereuromark
reviewed
Jun 2, 2021
|
Any update? Or shall we close this? |
|
Went ahead and updated these. Sorry on the delay. |
|
Do we want to continue and merge? |
|
Ping @MasterOdin |
|
I wonder if we might need a test case here to back things up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit of this PR handles #1972, which is to remove the use of NTEXT and replace it with NVARCHAR(MAX). The existing NTEXT and TEXT parsing to the Phinx TEXT type still exists for compatibility reasons.
The second commit forces default constraints to always be dropped and readded, as SQL Server requires this to be removed if the column is ever changed.