Clarify that a primary key is required #7936 #7939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehov
changed the title
ADmad
reviewed
Oct 25, 2024
| @@ -510,7 +510,7 @@ example above we would need tables for ``articles``, ``tags`` and | |||
| ``articles_tags``. The ``articles_tags`` table contains the data that links | |||
| tags and articles together. The joining table is named after the two tables | |||
| involved, separated with an underscore by convention. In its simplest form, this | |||
| table consists of ``article_id`` and ``tag_id``. | |||
| table consists of ``article_id`` and ``tag_id``, as well as `multiple-column ``PRIMARY KEY`` index <https://dev.mysql.com/doc/refman/8.4/en/create-table.html#idm44961976278224>`_ spanning both of these columns. | |||
There was a problem hiding this comment.
We can't assume that the reader is using MySQL.
There was a problem hiding this comment.
In its simplest form, this table consists of
article_idandtag_idas well as the default (primary key)id.
would be more correct either way.
Any multi colum setups are not simple or trivial here IMO.
There was a problem hiding this comment.
I think the link is the problematic part as it is MySQL specific, and seems like a URL that will rot due to the fragment id.
markstory
added a commit
that referenced
this pull request
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.