Update 4-0-upgrade-guide.rst #7912
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More skeleton-files need to be updated during 3.x to 4.x upgrade
Arhell
approved these changes
Sep 4, 2024
LordSimal
reviewed
Sep 4, 2024
| Next, ensure your files has been updated to have the same | ||
| method signatures as those found in cakephp/app. | ||
|
|
||
| #. ``src/Application.php`` at `Application.php <https://github.com/cakephp/app/blob/4.x/src/Application.php>`__ on GitHub. |
There was a problem hiding this comment.
Please use links to the 4.0.4 tag, not 4.x
4.x is current CakePHP 4.5 which should not be used as a base to upgrade Cake 3 to.
There was a problem hiding this comment.
You could also just reference the whole app template as it is done in the 5.0 upgrade guide instead of manually listing all the files
There was a problem hiding this comment.
Should the links for 4.0.0 tag be used, or 4.0.4 ?
Since it is only a few files that needs to be updated, I thought referencing them directly would be faster for users to upgrade.
There was a problem hiding this comment.
I agree that using concrete files will make them outdated and then lying over a short amount of time.
Better to stay more agnostic here.
markstory
reviewed
Sep 4, 2024
has -> have Co-authored-by: Mark Story <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More skeleton-files need to be updated during 3.x to 4.x upgrade