Bump up CakePHP and PHPUnit. #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADmad
commented
Aug 8, 2024
| @@ -111,7 +111,8 @@ public function execute(Arguments $args, ConsoleIo $io): ?int | |||
| } | |||
|
|
|||
| foreach ($tables as $table) { | |||
| $subArgs = new Arguments([$table], $options, ['name']); | |||
| $parser = $command->getOptionParser(); | |||
| $subArgs = new Arguments([$table], $options, $parser->argumentNames()); | |||
There was a problem hiding this comment.
This change is necessary to the avoid the ..argument not defined.. exception added in Cake 5.1. We need to ensure the command is executed with all it's defined args and not just name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't figure out the proper attributes to use for the
@coversannotations. So would be nice if someone could address that else we can drop the annotations.