WIP! Make sure custom relations work out with new alias strictness. #1015
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #1012
So basically 5.1 and the more strict relation-handling ("Association alias
Countries
is already set") kinda broke the non documented feature of custom relationship baking.Even though it was just baked wrongly with always the same Countries relation.
This PR already adds the expected aliasing back ensuring there is no collision, and having the correct name in the process for most cases:
as example for
Countries
Users
This would still need to get finished up inside Bake Model command of course.
Maybe someone wants to help out here.