Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payjoin #1806

Draft
wants to merge 14 commits into
base: update_app_deps
Choose a base branch
from
Draft

Payjoin #1806

wants to merge 14 commits into from

Conversation

J0J0XMR
Copy link

@J0J0XMR J0J0XMR commented Nov 14, 2024

This PR is a WIP.

The current bottle neck is that the PSBT being generated throws an error in internal PSBT data structure.

Cake uses PSBTv2 and Payjoin requires v0, so a conversion script is run after building the PSBT.
Testing the conversion script on a test PSBTv2 gives a valid v0, so the issue in how the v2 is created in electrum_wallet.dart using createPayjoinTransaction.

Raw hex, PSBT v0 & v2 strings are all printed in debug console for analysis.

Steps to reproduce:

  1. Create a PjURI by choosing "Payjoin" option from the drop-down menu on the Receive screen.
  2. Copy that PjURI and paste it in the Send form and press Send.

Note: Commits 25ae7c4 & 59ca8b1 include temporary deps and files needed to build and run this branch:

  • bitcoin_base & payjoin_flutter packages are on temporary forked repos until the fixes get included upstream.
  • bitcoin.dart is ignored by git and is needed to build, and will need to be updated again when merging to main.

@J0J0XMR J0J0XMR marked this pull request as draft November 14, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant