-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Payjoin #1806
Draft
J0J0XMR
wants to merge
14
commits into
cake-tech:update_app_deps
Choose a base branch
from
J0J0XMR:payjoin
base: update_app_deps
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Payjoin #1806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a WIP.
The current bottle neck is that the PSBT being generated throws an
error in internal PSBT data structure
.Cake uses PSBTv2 and Payjoin requires v0, so a conversion script is run after building the PSBT.
Testing the conversion script on a test PSBTv2 gives a valid v0, so the issue in how the v2 is created in
electrum_wallet.dart
usingcreatePayjoinTransaction
.Raw hex, PSBT v0 & v2 strings are all printed in debug console for analysis.
Steps to reproduce:
Note: Commits
25ae7c4
&59ca8b1
include temporary deps and files needed to build and run this branch: