Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CW-782: Show error report popup without cooldown #1739

Merged
merged 14 commits into from
Nov 28, 2024

Conversation

MrCyjaneK
Copy link
Collaborator

Description

improve exception throwing on broken wallets

  • put _lastOpenedWallet to avoid issues on windows (file is currently open by)
  • don't throw corruptedWalletsSeed - instead store it inside of secureStorage
  • await ExceptionHandler.onError calls where possible to makse sure that popup won't be canceled by some UI element
  • adjust BaseAlertDialog to be scrollable if the text is too long
  • add ExceptionHandler.resetLastPopupDate - that can be called when we want to show error report screen (bypassing cooldown)

Pull Request - Checklist

  • Initial Manual Tests Passed
  • Double check modified code and verify it with the feature/task requirements
  • Format code
  • Look for code duplication
  • Clear naming for variables and methods

- put _lastOpenedWallet to avoid issues on windows (file is currently open by)
- don't throw corruptedWalletsSeed - instead store it inside of secureStorage
- await ExceptionHandler.onError calls where possible to makse sure that popup won't be canceled by some UI element
- adjust BaseAlertDialog to be scrollable if the text is too long
- add ExceptionHandler.resetLastPopupDate - that can be called when we want to show error report screen (bypassing cooldown)
@MrCyjaneK MrCyjaneK force-pushed the CW-782-show-error-report-popup-without-cooldown branch from e40177e to 212e59b Compare October 10, 2024 15:54
@MrCyjaneK MrCyjaneK force-pushed the CW-782-show-error-report-popup-without-cooldown branch from 8fa3993 to d7327ce Compare October 14, 2024 10:06
lib/core/backup_service.dart Outdated Show resolved Hide resolved
lib/core/wallet_loading_service.dart Outdated Show resolved Hide resolved
lib/utils/exception_handler.dart Outdated Show resolved Hide resolved
lib/utils/exception_handler.dart Outdated Show resolved Hide resolved
lib/src/screens/wallet_list/wallet_list_page.dart Outdated Show resolved Hide resolved
@MrCyjaneK MrCyjaneK force-pushed the CW-782-show-error-report-popup-without-cooldown branch from 5b72be3 to 159f433 Compare October 17, 2024 10:41
@MrCyjaneK MrCyjaneK force-pushed the CW-782-show-error-report-popup-without-cooldown branch from 695f899 to a315a31 Compare November 28, 2024 19:27
@OmarHatem28 OmarHatem28 merged commit 17d34be into main Nov 28, 2024
0 of 2 checks passed
@OmarHatem28 OmarHatem28 deleted the CW-782-show-error-report-popup-without-cooldown branch November 28, 2024 19:28
Copy link

@xximwon xximwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

G

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants