CW-673: Save Haven seeds to show it to the user after Haven removal #1518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er-after-haven-removal
…er-after-haven-removal
OmarHatem28
requested changes
Nov 21, 2024
…ds-to-show-it-to-the-user-after-haven-removal
OmarHatem28
approved these changes
Dec 11, 2024
…er-after-haven-removal
remove print
OmarHatem28
deleted the
CW-673-save-haven-seeds-to-show-it-to-the-user-after-haven-removal
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR doesn't remove haven yet but it does store the seed internally. In another PR (opened against this branch, or main once this gets merged) I'll remove haven support - so users actually will have time to open the wallet and withdraw funds, and since the library is still required to extract the seeds, we may as well let them use the wallet, and hope for them to notice the warning about haven removal.
Pull Request - Checklist