litecoin mweb support #1455
litecoin mweb support #1455
Conversation
cw_bitcoin/lib/litecoin_wallet.dart
Outdated
| _stuckSyncTimer = Timer.periodic(const Duration(seconds: 10), (timer) async { | ||
| if (syncStatus is! SyncingSyncStatus) return; | ||
| if (syncStatus.progress() > 0.98) return; // don't check if we're close to synced | ||
| lastFewProgresses.add(syncStatus.progress()); | ||
| if (lastFewProgresses.length < 10) return; | ||
| // limit list size to 10: | ||
| while (lastFewProgresses.length > 10) { | ||
| lastFewProgresses.removeAt(0); | ||
| } |
There was a problem hiding this comment.
10 seconds and you need 10 to trigger the resync, so 100 seconds, isn't that a bit long to just restart synchronization?
There was a problem hiding this comment.
it's intentionally long as it was triggering unnecessarily, but it's more meant so that background sync doesn't get stuck forever more than anything
we can probably just move this code into the background sync branch so that it applies to all wallet types, since it doesn't do much for the foreground state anyways
There was a problem hiding this comment.
removed in the latest commit (and added to the mweb-bg-sync-2 branch)
cw_bitcoin/lib/litecoin_wallet.dart
Outdated
| // if our address isn't in the inputs, update the txCount: | ||
| final inputAddresses = tx.inputAddresses ?? []; | ||
| if (!inputAddresses.contains(utxo.address)) { | ||
| addressRecord.txCount++; | ||
| } |
There was a problem hiding this comment.
shouldn't we update the count anyway?
| tx.isPending = false; | ||
| await transactionHistory.save(); | ||
| return true; |
| // check if the transaction doesn't contain any mweb inputs or outputs: | ||
| final transactionCredentials = credentials as BitcoinTransactionCredentials; | ||
|
|
||
| bool hasMwebInput = false; | ||
| bool hasMwebOutput = false; | ||
|
|
||
| for (final output in transactionCredentials.outputs) { | ||
| if (output.extractedAddress?.toLowerCase().contains("mweb") ?? false) { | ||
| hasMwebOutput = true; | ||
| break; | ||
| } | ||
| } | ||
|
|
||
| if (tx2.mwebBytes != null && tx2.mwebBytes!.isNotEmpty) { | ||
| hasMwebInput = true; | ||
| } | ||
|
|
||
| if (!hasMwebInput && !hasMwebOutput) { | ||
| return tx; | ||
| } |
There was a problem hiding this comment.
Enhancement:
would have been better to do it right before/after the if (!mwebEnabled) check, so we don't await some functions that we don't need
also what about the TODO you added regarding type casting BitcoinScriptOutput?
it should work, otherwise the compiler would have flagged it as non supported type
Issue Number (if Applicable): Fixes #
Description
Please include a summary of the changes and which issue is fixed / feature is added.
Pull Request - Checklist