reverseproxy: Allow 0 as weights for weighted_round_robin
#6388
Conversation
|
|
| if weightInt < 1 { | ||
| return d.Errf("invalid weight value '%s': weight should be non-zero and positive", weight) | ||
| if weightInt < 0 { | ||
| return d.Errf("invalid weight value '%s': weight should be positive", weight) |
There was a problem hiding this comment.
| return d.Errf("invalid weight value '%s': weight should be positive", weight) | |
| return d.Errf("invalid weight value '%s': weight should be non-negative", weight) |
0 isn't positive but is also allowed now 😉
There was a problem hiding this comment.
Good question, I don't have the enough knowledge to write the test case for this. Any guide would be helpful.
There was a problem hiding this comment.
Have you at least tested various configs yourself to ensure they work? If so that's probably enough to start with.
But it looks like the existing tests are in selectionpolicies_test.go at func TestWeightedRoundRobinPolicy(t *testing.T) {. You could test a zero-weight in there as well.
There was a problem hiding this comment.
Thank you for your reply, will work on generating the test case.
There was a problem hiding this comment.
@peanutduck this still needs tests. Are you interested in finishing this up?
Change positive to non-negative
francislavoie
changed the title
0 as weights for weighted_round_robin
Enable 0 weights to be allowed when using weighted_round_robin policy with cookie. Discussed in https://caddy.community/t/invalid-weight-value/24440