Fix the mono runtime test config #958

lewing · 2024-05-29T22:18:14Z

Update the build to get things working with the latest mono net9 targets

mkhamoyan · 2024-06-26T15:11:41Z

@lewing dotnet/runtime#103881 fixed the conflicting naming error, but now when running wit-bindgen with this PR changes I see this failure

Because of this I couldn't validate if the fix is enough.

lewing · 2024-07-09T16:19:06Z

test result: ok. 27 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 965.25s

need to look at the performance here but csharp-mono tests are green with these changes

lewing · 2024-08-30T16:50:20Z

@dicej
with this version I'm seeing errors like

---- variants::run stdout ----
Error: failed to read component type file: VariantsWorld_component_type.o

Caused by:
    The system cannot find the file specified. (os error 2)

any thoughts?

jsturtevant · 2024-08-30T16:58:38Z

crates/csharp/src/csproj.rs

@@ -190,9 +195,17 @@ impl CSProjectMonoBuilder {
        </PropertyGroup>

        <ItemGroup>
-          <NativeFileReference Include=\"{camel}_component_type.o\" Condition=\"Exists('{camel}_component_type.o')\"/>
+          <_WasiLinkStepArgs Include=\"-Wl,--component-type,{camel}_component_type.wit\" />
+          <!-- both versions of these seem to fail to find the .o


Wit-bindgen doesn't produce the object file directly anymore,

I've used:

<CustomLinkerArg Include="@(WitComponentImports->Replace('\', '/')->'-Wl,--component-type,"%(Identity)"')" />

In https://github.com/bytecodealliance/componentize-dotnet/pull/35/files#diff-7f4dfa8be7454aa047e35760bfbb0f95c0e1402fd34943606ccd9975e45b8b71

Not sure if _WasiLinkStepArgs is the same?

it's another case of bad coevolution dotnet/runtime#107194 but they will be

The resolution there is that everybody should use LinkerArg over all the other options

lewing · 2024-08-30T16:58:47Z

@dicej with this version I'm seeing errors like

---- variants::run stdout ----
Error: failed to read component type file: VariantsWorld_component_type.o

Caused by:
    The system cannot find the file specified. (os error 2)

any thoughts?

haha, I see the problem now. That is what I get for not looking again in the morning before.

dicej · 2024-08-30T16:59:39Z

@dicej with this version I'm seeing errors like

---- variants::run stdout ----
Error: failed to read component type file: VariantsWorld_component_type.o

Caused by:
    The system cannot find the file specified. (os error 2)

any thoughts?

As of dotnet/runtime#103752, the *_component_type.o files have been replaced with *_component_type.wit files. Perhaps you're using an older runtime?

lewing · 2024-08-30T17:03:09Z

@dicej with this version I'm seeing errors like
---- variants::run stdout ----
Error: failed to read component type file: VariantsWorld_component_type.o

Caused by:
    The system cannot find the file specified. (os error 2)
any thoughts?
As of dotnet/runtime#103752, the *_component_type.o files have been replaced with *_component_type.wit files. Perhaps you're using an older runtime?

Sadly I was rushing to get it working last night before heading out, I should have looked again this morning. Sorry for the noise.

…o different places

lewing · 2024-08-30T20:37:02Z

Ok, so it was also very confusing that the features were chained so the native aot test build was writing over the mono tests once the compilation issue was fixed.

the 'NuGet-Migrations failure is not related to these changes .

There do now appear to be a couple of failures on the mono side dotnet/runtime#107212

pavelsavara · 2024-09-02T12:46:10Z

crates/csharp/src/csproj.rs

-            true => format!("<WasmBuildNative>{aot}</WasmBuildNative>"),
-            false => String::new(),
-        };
+        let tfm = "net9.0";


Should we move to Net10 ?
Because we are not going to backport fixes to Net9, right ?
One more below.

there won't be a working net10 sdk for a while unfortunately

pavelsavara · 2024-09-02T13:45:09Z

tests/runtime/main.rs

+            let out_wasm = out_dir
+                .join("bin")
+                .join(configuration)
+                .join("net9.0")


that is only one of the issues here, build doesn't respect the project name, and the publish doesn't respect the output directory. @maraf we should discuss what options we have here

pavelsavara · 2024-09-02T14:37:29Z

tests/runtime/main.rs

                .arg(out_dir.join(format!("{camel}.csproj")))
                .arg("-c")
-                .arg("Debug")
+                .arg(configuration)
                .arg("/p:PlatformTarget=AnyCPU")
                .arg("--self-contained")


for me --self-contained doesn't' work with 9.0.100-preview.6.24328.19 without workload. The publish doesn't fail but the file is located elsewhere and it's not single file.

After I install workload Microsoft.NET.Runtime.WebAssembly.Wasi.Sdk version 9.0.0-preview.6.24327.7 I get

FooWorld failed with 4 error(s) (11.4s) → xxx\ wasm-ld : error : unknown argument: --component-type wasm-ld : error : unknown file type: FooWorld_component_type.wit

Which makes sense for preview6.

With preview7 I get

1: error while executing at wasm backtrace: 0: 0x296a7b - .tmpJCkP17!fseek 1: 0x8efe - .tmpJCkP17!load_icu_data 2: 0x8ff4 - .tmpJCkP17!mono_wasm_load_runtime 3: 0x9299 - .tmpJCkP17!initialize_runtime 4: 0x92b8 - .tmpJCkP17!main 5: 0x28bc5c - .tmpJCkP17!__main_void 6: 0x7e78 - .tmpJCkP17!_start 7: 0xb40aff - wit-component:adapter:wasi_snapshot_preview1!wasi:cli/[email protected]#run

Which means <WasmSingleFileBundle>true</WasmSingleFileBundle> didn't work.

nothing about this will work without the workload, I'm testing against daily builds of 9

using https://learn.microsoft.com/en-us/dotnet/core/tools/dotnet-install-script
and dotnet-install -c 9.0 -q daily

I had to add <WasmBuildNative>true</WasmBuildNative> to get it to produce a single file

pavelsavara · 2024-09-02T14:45:01Z

tests/runtime/main.rs

                .arg(out_dir.join(format!("{camel}.csproj")))
                .arg("-c")
-                .arg("Debug")
+                .arg(configuration)


Suggested change

.arg(configuration)

.arg(configuration)

.arg("-bl:publish-mono.binlog")

lewing · 2024-09-15T20:18:10Z

Several of the issues I hit should be fixed in dotnet/runtime main, but it testing that will be challenging until a proper net10 sdk is produced.

lewing mentioned this pull request May 30, 2024

[wasm][mono] conflicting naming for wasm import/export dotnet/runtime#102844

Closed

lewing force-pushed the lewing-test branch from c65d308 to c2c286d Compare July 9, 2024 15:19

lewing added 4 commits August 29, 2024 18:02

Fix the mono runtime test config

d6da02a

Some of this will get removed again

dbab743

Link in the realloc stub

43ca36b

Tweak the output path again and attempt to resolve the component linking

1b1d549

lewing force-pushed the lewing-test branch from 103cada to 1b1d549 Compare August 30, 2024 16:48

jsturtevant reviewed Aug 30, 2024

View reviewed changes

Remove the code causing the problem

631156d

lewing added 2 commits August 30, 2024 12:13

Small fixes

902e792

don't enable csharp when csharp-mono is enabled and make them write t…

60295c5

…o different places

lewing mentioned this pull request Aug 30, 2024

[wasi] Failures in wit-bindgen runtime tests on mono dotnet/runtime#107212

Open

lewing added 2 commits August 30, 2024 16:03

Remove some unrelated changes

22bbc58

More cleanup

08ae2d8

pavelsavara reviewed Sep 2, 2024

View reviewed changes

jsturtevant mentioned this pull request Nov 6, 2024

c#: Mono runtime tests #1079

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix the mono runtime test config #958

Fix the mono runtime test config #958

lewing commented May 29, 2024 •

edited

Loading

mkhamoyan commented Jun 26, 2024

lewing commented Jul 9, 2024 •

edited

Loading

lewing commented Aug 30, 2024 •

edited

Loading

jsturtevant Aug 30, 2024

lewing Aug 30, 2024

lewing Sep 11, 2024

lewing commented Aug 30, 2024

dicej commented Aug 30, 2024

lewing commented Aug 30, 2024

lewing commented Aug 30, 2024

pavelsavara Sep 2, 2024

lewing Sep 6, 2024

pavelsavara Sep 2, 2024

lewing Sep 6, 2024

pavelsavara Sep 2, 2024 •

edited

Loading

lewing Sep 6, 2024 •

edited

Loading

jsturtevant Sep 11, 2024

pavelsavara Sep 2, 2024

lewing commented Sep 15, 2024

	.arg(configuration)
	.arg(configuration)
	.arg("-bl:publish-mono.binlog")

Fix the mono runtime test config #958

Are you sure you want to change the base?

Fix the mono runtime test config #958

Conversation

lewing commented May 29, 2024 • edited Loading

mkhamoyan commented Jun 26, 2024

lewing commented Jul 9, 2024 • edited Loading

lewing commented Aug 30, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lewing commented Aug 30, 2024

dicej commented Aug 30, 2024

lewing commented Aug 30, 2024

lewing commented Aug 30, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pavelsavara Sep 2, 2024 • edited Loading

Choose a reason for hiding this comment

lewing Sep 6, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lewing commented Sep 15, 2024

lewing commented May 29, 2024 •

edited

Loading

lewing commented Jul 9, 2024 •

edited

Loading

lewing commented Aug 30, 2024 •

edited

Loading

pavelsavara Sep 2, 2024 •

edited

Loading

lewing Sep 6, 2024 •

edited

Loading