initial adaptation to automatic wasm32/64 offsets #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
added a commit
to alexcrichton/witx-bindgen
that referenced
this pull request
Aug 22, 2024
This notably updates to handle bytecodealliance/wasm-tools#1711 but this is done in a way that is not intended to replace bytecodealliance#1035 but instead makes the update "as easy as possible" by just adding calls to `.{size,align}_wasm32()` where needed. Full support is expected to land in bytecodealliance#1035.
alexcrichton
added a commit
to alexcrichton/witx-bindgen
that referenced
this pull request
Aug 22, 2024
This notably updates to handle bytecodealliance/wasm-tools#1711 but this is done in a way that is not intended to replace bytecodealliance#1035 but instead makes the update "as easy as possible" by just adding calls to `.{size,align}_wasm32()` where needed. Full support is expected to land in bytecodealliance#1035.
This notably updates to handle bytecodealliance/wasm-tools#1711 but this is done in a way that is not intended to replace bytecodealliance#1035 but instead makes the update "as easy as possible" by just adding calls to `.{size,align}_wasm32()` where needed. Full support is expected to land in bytecodealliance#1035.
|
Thank you, I hope #1036 wasn't too much of an effort, I am still working on finishing this. |
|
No problem! |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 23, 2024
* Update wasm-tools dependencies This notably updates to handle bytecodealliance/wasm-tools#1711 but this is done in a way that is not intended to replace #1035 but instead makes the update "as easy as possible" by just adding calls to `.{size,align}_wasm32()` where needed. Full support is expected to land in #1035. * More sizing updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very minimal adaptation to the new wasm32/64 offset calculation of wit-parser, the generated code is likely still incorrect as the default Display implementation isn't language independent.