Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some missing configuration flags (#227) #236

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

bobappleyard
Copy link
Contributor

By my reckoning, the following configuration flags were missing as of today:

wasmtime_config_wasm_tail_call_set
wasmtime_config_wasm_function_references_set
wasmtime_config_wasm_gc_set
wasmtime_config_wasm_wide_arithmetic_set
wasmtime_config_parallel_compilation_set
wasmtime_config_cranelift_nan_canonicalization_set
wasmtime_config_static_memory_forced_set
wasmtime_config_native_unwind_info_set
wasmtime_config_macos_use_mach_ports_set
wasmtime_config_memory_init_cow_set
wasmtime_config_async_support_set

With the exception of wasmtime_config_async_support_set, these flags are now included and should be settable.

It looks like wasmtime_config_async_support_set has a load of other settings that are needed in order to get it to work, so I'm skipping that one. Given how Go works, that would require a lot of thought, and I have taken a very mechanical approach here.

Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

config.go Outdated Show resolved Hide resolved
@alexcrichton alexcrichton merged commit 953b6bc into bytecodealliance:main Dec 4, 2024
10 checks passed
@alexcrichton
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants