new: Add WasiCtx #190
Closed
new: Add WasiCtx #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reflecting C-API changes made in bytecodealliance/wasmtime#7001 by adding incomplete implementation for `WasiCtx`: - `func (store *Store) GetWasiCtx() *WasiCtx` - `func (c *WasiConfig) PreopenTCPSocket(innerFD uint32, hostPort string) error`*: not a part of `WasiCtx`, but adding it since it was already there in C-API. - `type WasiFileAccessMode uint32`* - `type WasiCtx struct` - `(*WasiCtx).InsertFile(guestFD uint32, file *os.File, accessMode WasiFileAccessMode)` - `(*WasiCtx).PushFile(file *os.File, accessMode WasiFileAccessMode) (uint32, error)` *: Credit goes to @jmwample. --------- Co-authored-by: jmwample <[email protected]>
Redesign `WasiCtx` to wrap a *Store. Revise the member functions to call `wasmtime_context_*` functions from C-API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reflecting C-API changes made in bytecodealliance/wasmtime#7001 by adding incomplete implementation for
WasiCtx:func (store *Store) GetWasiCtx() *WasiCtxfunc (c *WasiConfig) PreopenTCPSocket(innerFD uint32, hostPort string) error*: not a part ofWasiCtx, but adding it since it was already there in C-API.type WasiFileAccessMode uint32*type WasiCtx struct(*WasiCtx).InsertFile(guestFD uint32, file *os.File, accessMode WasiFileAccessMode)(*WasiCtx).PushFile(file *os.File, accessMode WasiFileAccessMode) (uint32, error)*: Credit goes to @jmwample.
This pull request depends on the pull request editing the C-API, and has been discussed here: #187