feat: Added AUTH packet support for enhanced authentication. #852
Conversation
| options.keep_alive = Duration::from_secs(keep_alive as u64); | ||
| } | ||
| network.set_max_outgoing_size(props.max_packet_size); | ||
| loop { |
There was a problem hiding this comment.
There are two ways to do this, one as has been already implemented in this PR, the other would involve improving the visibility into the whole process, updating the event log and returning events as they occur.
Example log of events
- Outgoing Connect packet
- Incoming/Outgoing Auth packets for as long as the challenge/response cycle goes on
- Incoming Connack packet
This would require a refactor of how the code is currently structured, let me delve deeper into this.
There was a problem hiding this comment.
Is there any update on involve improving the visibility into the whole process, updating the event log and returning events as they occur?
Please reference the following docs for the testing guidance: |
… chxiao/auth_support
Update auth_continue API.
|
Attached updated design doc. |
Fix Send issue between threads.
Fix testing.
Fix compile warnings.
Pull Request Test Coverage Report for Build 9540617300Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Type of change
New feature (non-breaking change which adds functionality)
Checklist:
cargo fmtCHANGELOG.mdif it's relevant to the users of the library. If it's not relevant mention why.Resolves #840