Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a wrongly generated doc for to many relations #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Rocksheep
Copy link

@Rocksheep Rocksheep commented Aug 28, 2021

When a relation what specified as a to many relationship it would generate a wrong documentation for the detach endpoint.
Before my fix it expected an object instead of an array.

Before this fix:

{
    "data": {
        "type": "tags",
        "id": "<string>"
    }
}

After this fix:

{
    "data": [
        {
            "type": "tags",
            "id": "<string>"
        },
        {
            "type": "tags",
            "id": "<string>"
        }
    ]
}

The to many relationship had an incorrect type description for the detach endpoint. This commit fixes that issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant