Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix rules for isbetween that was not validated. #47

Merged
merged 4 commits into from
Jul 21, 2024

Conversation

bvanelli
Copy link
Owner

@bvanelli bvanelli commented Jul 21, 2024

Turns out isbetween does not share the model with any of the other of the the other entries, but rather implementes the the following data model:

{"num1": int1, "num2": int2}

This patch files this broken behaviour.

Closes #46

Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.81%. Comparing base (c59a360) to head (126ad84).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
+ Coverage   96.77%   96.81%   +0.03%     
==========================================
  Files          13       13              
  Lines        1738     1758      +20     
==========================================
+ Hits         1682     1702      +20     
  Misses         56       56              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bvanelli bvanelli merged commit 0ca0487 into main Jul 21, 2024
7 checks passed
@bvanelli bvanelli deleted the 46-rule-validation-error branch July 21, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when trying to run rules or evaluate rules
1 participant