Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct model for latest actual server. #42

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

bvanelli
Copy link
Owner

@bvanelli bvanelli commented Jul 15, 2024

Closes #39

I tested with the missing column, and the model seems to work.

I also added a test to check for missing columns in one of the tests, so that they cannot be missed in the future.

image

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.75%. Comparing base (1981fcc) to head (b64ce39).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
+ Coverage   96.69%   96.75%   +0.06%     
==========================================
  Files          13       13              
  Lines        1725     1728       +3     
==========================================
+ Hits         1668     1672       +4     
+ Misses         57       56       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bvanelli bvanelli merged commit 86aac7f into main Jul 15, 2024
7 checks passed
@bvanelli bvanelli deleted the 39-custom-report-include-current-column branch July 15, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New custom report options are causing an error loading the budget.
1 participant